接口优化

cv/billboard_cv/billboard.go

@@ -8,7 +8,6 @@ import (
 	"hilo-group/_const/enum/gift_e"
 	"hilo-group/_const/redis_key"
 	"hilo-group/cv/gift_cv"
-	"hilo-group/cv/group_cv"
 	"hilo-group/cv/user_cv"
 	"sort"
 	"strconv"
@@ -26,7 +25,7 @@ type BillboardUserInfo struct {
 //榜单中用户信息
 type GroupTop3ConsumeUser struct {
 	//用户基本信息
-	UserBase group_cv.TopConsumersUser `json:"userBase"`
+	UserBase user_cv.TopConsumersUser `json:"userBase"`
 	//数值
 	Num uint64 `json:"num"`
 }
@@ -68,7 +67,15 @@ func GetGroupTop3Consume(model *domain.Model, groupId string, myUserId uint64) (
 		ret, err := saveGroupTop3Consume(period, groupId, diamonds)
 
 		model.Log.Infof("GetGroupTop3Consume SAVE ret = %d, err: %v", ret, err)
-		return result, nil
+
+		list := make([]GroupTop3ConsumeUser, 0, len(result))
+		for _, v := range result {
+			list = append(list, GroupTop3ConsumeUser{
+				UserBase: user_cv.TopConsumersUser{Id: v.UserBase.Id, Avatar: v.UserBase.Avatar, ExternalId: v.UserBase.ExternalId, Nick: v.UserBase.Nick},
+			})
+		}
+
+		return list, nil
 	}
 
 	userIds := make([]uint64, 0)
@@ -99,7 +106,7 @@ func GetGroupTop3Consume(model *domain.Model, groupId string, myUserId uint64) (
 	list := make([]GroupTop3ConsumeUser, 0, len(result))
 	for _, v := range result {
 		list = append(list, GroupTop3ConsumeUser{
-			UserBase: group_cv.TopConsumersUser{Id: v.UserBase.Id, Avatar: v.UserBase.Avatar, ExternalId: v.UserBase.ExternalId, Nick: v.UserBase.Nick},
+			UserBase: user_cv.TopConsumersUser{Id: v.UserBase.Id, Avatar: v.UserBase.Avatar, ExternalId: v.UserBase.ExternalId, Nick: v.UserBase.Nick},
 		})
 	}
 

cv/group_cv/group.go

@@ -2,7 +2,6 @@ package group_cv
 
 import (
 	"git.hilo.cn/hilo-common/domain"
-	"git.hilo.cn/hilo-common/resource/mysql"
 	"git.hilo.cn/hilo-common/utils"
 	"hilo-group/_const/enum/game_e"
 	"hilo-group/_const/enum/groupPower_e"
@@ -147,17 +146,6 @@ type GroupDetail struct {
 	Owner       *user_cv.CvUserDetail `json:"owner"` // 群主信息
 }
 
-type TopConsumersUser struct {
-	//不会有返回值
-	Id *mysql.ID `json:"id,omitempty"`
-	//头像,不存在为nil
-	Avatar *string `json:"avatar"`
-	//用户对外ID
-	ExternalId *string `json:"externalId"`
-	//昵称,不存在为nil
-	Nick *string `json:"nick"`
-}
-
 type SimpleRoleInfo struct {
 	ExternalId string                `json:"externalId"`
 	Role       group_e.GroupRoleType `json:"role"`

cv/user_cv/user.go

@@ -1324,3 +1324,14 @@ func UserDetailToRoomInfoOwner(user *CvUserDetail) *RoomInfoOwner {
 		GroupPower:       user.GroupPower,
 	}
 }
+
+type TopConsumersUser struct {
+	//不会有返回值
+	Id *mysql.ID `json:"id,omitempty"`
+	//头像,不存在为nil
+	Avatar *string `json:"avatar"`
+	//用户对外ID
+	ExternalId *string `json:"externalId"`
+	//昵称,不存在为nil
+	Nick *string `json:"nick"`
+}